netdev - Re: [PATCH] net: fix decnet rtnexthop parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160705.140858.1158586328624337181.davem@davemloft.net>
Date:	Tue, 05 Jul 2016 14:08:58 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	vegard.nossum@...cle.com
Cc:	netdev@...r.kernel.org, tgraf@...g.ch
Subject: Re: [PATCH] net: fix decnet rtnexthop parsing

From: Vegard Nossum <vegard.nossum@...cle.com>
Date: Tue,  5 Jul 2016 21:12:53 +0200

> dn_fib_count_nhs() could enter an infinite loop if nhp->rtnh_len == 0
> (i.e. if userspace passes a malformed netlink message).
> 
> Let's use the helpers from net/nexthop.h which take care of all this
> stuff. We can do exactly the same as e.g. fib_count_nexthops() and
> fib_get_nhs() from net/ipv4/fib_semantics.c.
> 
> This fixes the softlockup for me.
> 
> Cc: Thomas Graf <tgraf@...g.ch>
> Signed-off-by: Vegard Nossum <vegard.nossum@...cle.com>

Applied, thanks.