netdev - Re: [PATCH net] ipv6: Fix mem leak in rt6i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160705.140949.1356441872073525132.davem@davemloft.net>
Date:	Tue, 05 Jul 2016 14:09:49 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	kafai@...com
Cc:	netdev@...r.kernel.org, kernel-team@...com,
	hannes@...essinduktion.org, pety@...net.ru
Subject: Re: [PATCH net] ipv6: Fix mem leak in rt6i_pcpu

From: Martin KaFai Lau <kafai@...com>
Date: Tue, 5 Jul 2016 12:10:23 -0700

> It was first reported and reproduced by Petr (thanks!) in
> https://bugzilla.kernel.org/show_bug.cgi?id=119581
> 
> free_percpu(rt->rt6i_pcpu) used to always happen in ip6_dst_destroy().
> 
> However, after fixing a deadlock bug in
> commit 9c7370a166b4 ("ipv6: Fix a potential deadlock when creating pcpu rt"),
> free_percpu() is not called before setting non_pcpu_rt->rt6i_pcpu to NULL.
> 
> It is worth to note that rt6i_pcpu is protected by table->tb6_lock.
> 
> kmemleak somehow did not report it.  We nailed it down by
> observing the pcpu entries in /proc/vmallocinfo (first suggested
> by Hannes, thanks!).
> 
> Signed-off-by: Martin KaFai Lau <kafai@...com>
> Fixes: 9c7370a166b4 ("ipv6: Fix a potential deadlock when creating pcpu rt")
> Reported-by: Petr Novopashenniy <pety@...net.ru>
> Tested-by: Petr Novopashenniy <pety@...net.ru>
> Acked-by: Hannes Frederic Sowa <hannes@...essinduktion.org>
> Cc: Hannes Frederic Sowa <hannes@...essinduktion.org>
> Cc: Petr Novopashenniy <pety@...net.ru>

Applied and queued up for -stable.