netdev - Re: [PATCH net-next 3/9] net: r6040: Utilize skb_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 6 Jul 2016 00:44:55 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Florian Fainelli <f.fainelli@...il.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH net-next 3/9] net: r6040: Utilize skb_put_padto()

Florian Fainelli <f.fainelli@...il.com> :
[...]
> diff --git a/drivers/net/ethernet/rdc/r6040.c b/drivers/net/ethernet/rdc/r6040.c
> index 75776eee36f9..46ed093348da 100644
> --- a/drivers/net/ethernet/rdc/r6040.c
> +++ b/drivers/net/ethernet/rdc/r6040.c
> @@ -815,6 +815,9 @@ static netdev_tx_t r6040_start_xmit(struct sk_buff *skb,
>  	void __iomem *ioaddr = lp->base;
>  	unsigned long flags;
>  
> +	if (skb_put_padto(skb, ETH_ZLEN) < 0)
> +		return NETDEV_TX_OK;
> +

Missing dev->stats->tx_dropped++.

-- 
Ueimor