netdev - Re: [oss-drivers] [PATCH][V2] nfp: check idx is -ENOSPC before using it is an index

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160711165943.09c3c519@jkicinski-Precision-T1700>
Date:	Mon, 11 Jul 2016 16:59:43 +0100
From:	Jakub Kicinski <jakub.kicinski@...ronome.com>
To:	Colin King <colin.king@...onical.com>
Cc:	Lauro Ramos Venancio <lauro.venancio@...nbossa.org>,
	Aloisio Almeida Jr <aloisio.almeida@...nbossa.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	"David S . Miller" <davem@...emloft.net>,
	Rolf Neugebauer <rolf.neugebauer@...ronome.com>,
	Christophe Ricard <christophe.ricard@...il.com>,
	Robert Dolca <robert.dolca@...el.com>,
	oss-drivers@...ronome.com, netdev@...r.kernel.org,
	linux-wireless@...r.kernel.org
Subject: Re: [oss-drivers] [PATCH][V2] nfp: check idx is -ENOSPC before
 using it is an index

On Mon, 11 Jul 2016 16:54:20 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> idx can be returned as -ENOSPC, so we should check for this first
> before using it as an index into nn->vxlan_usecnt[] to avoid an
> out of bounds array offset read.
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Acked-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

Thanks!