netdev - Re: [net-next 0/6] common library for Chelsio drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160711.125021.1679165284508297380.davem@davemloft.net>
Date:	Mon, 11 Jul 2016 12:50:21 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	varun@...lsio.com
Cc:	netdev@...r.kernel.org, linux-scsi@...r.kernel.org,
	target-devel@...r.kernel.org, nab@...ux-iscsi.org,
	gerlitz.or@...il.com, swise@...ngridcomputing.com,
	james.bottomley@...senpartnership.com, indranil@...lsio.com
Subject: Re: [net-next 0/6] common library for Chelsio drivers

From: Varun Prakash <varun@...lsio.com>
Date: Fri,  8 Jul 2016 23:03:53 +0530

> Hi,
> 
>  This patch series adds common library module(libcxgb.ko)
> for Chelsio drivers to remove duplicate code.
> 
> This series moves common iSCSI DDP Page Pod manager
> code from cxgb4.ko to libcxgb.ko, earlier this code
> was used by only cxgbit.ko now it is used by
> three Chelsio iSCSI drivers cxgb3i, cxgb4i, cxgbit.
> 
> In future this module will have common connection
> management and hardware specific code that can
> be shared by multiple Chelsio drivers(cxgb4,
> csiostor, iw_cxgb4, cxgb4i, cxgbit).
> 
> Please review.

As currently implemented the user is prompted for the Kconfig symbol
for the library.  That really needs to be hidden from the user and
they should be able to select these drivers without having to know
about this implementation detail at all.