netdev - RE: [net-next 0/6] common library for Chelsio drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <012801d1dbae$22288b90$6679a2b0$@opengridcomputing.com>
Date:	Mon, 11 Jul 2016 14:55:11 -0500
From:	"Steve Wise" <swise@...ngridcomputing.com>
To:	"'David Miller'" <davem@...emloft.net>, <varun@...lsio.com>
Cc:	<netdev@...r.kernel.org>, <linux-scsi@...r.kernel.org>,
	<target-devel@...r.kernel.org>, <nab@...ux-iscsi.org>,
	<gerlitz.or@...il.com>, <james.bottomley@...senpartnership.com>,
	<indranil@...lsio.com>
Subject: RE: [net-next 0/6] common library for Chelsio drivers

> > Hi,
> >
> >  This patch series adds common library module(libcxgb.ko)
> > for Chelsio drivers to remove duplicate code.
> >
> > This series moves common iSCSI DDP Page Pod manager
> > code from cxgb4.ko to libcxgb.ko, earlier this code
> > was used by only cxgbit.ko now it is used by
> > three Chelsio iSCSI drivers cxgb3i, cxgb4i, cxgbit.
> >
> > In future this module will have common connection
> > management and hardware specific code that can
> > be shared by multiple Chelsio drivers(cxgb4,
> > csiostor, iw_cxgb4, cxgb4i, cxgbit).
> >
> > Please review.
> 
> As currently implemented the user is prompted for the Kconfig symbol
> for the library.  That really needs to be hidden from the user and
> they should be able to select these drivers without having to know
> about this implementation detail at all.

Maybe adding something like:

select CHELSIO_LIB

to the Kconfig files for the drivers that are depenedent on CHELSIO_LIB?