netdev - Re: [PATCH net] tcp_timer.c: Add kernel-doc function descriptions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160711.125630.317058844992527133.davem@davemloft.net>
Date:	Mon, 11 Jul 2016 12:56:30 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	richard@...traumpflege.org
Cc:	netdev@...r.kernel.org, kuznet@....inr.ac.ru, jmorris@...ei.org
Subject: Re: [PATCH net] tcp_timer.c: Add kernel-doc function descriptions

From: Richard Sailer <richard@...traumpflege.org>
Date: Fri,  8 Jul 2016 22:58:26 +0200

>  
> +/**
> + *   tcp_write_err() - close socket and save error info.
> + *   @sk:  The socket the error has appeared on.
> + *
> + *   Returns: Nothing (void)
> + */
> +
...
> +/**
> + * tcp_out_of_resources() - Close socket if out of resources
> + * @sk:        pointer to current socket
> + * @do_reset:  send a last packet with reset flag
> + *
> + * Do not allow orphaned sockets to eat all our resources.
>   * This is direct violation of TCP specs, but it is required
>   * to prevent DoS attacks. It is called when a retransmission timeout
>   * or zero probe timeout occurs on orphaned socket.

Please indent your comments consistently.