netdev - Re: [PATCH 1/3] net: smsc911x: augment device tree bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160715190341.GA12624@rob-hp-laptop>
Date:	Fri, 15 Jul 2016 14:03:41 -0500
From:	Rob Herring <robh@...nel.org>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
	Steve Glendinning <steve.glendinning@...c.com>,
	Guenter Roeck <linux@...ck-us.net>,
	Jeremy Linton <jeremy.linton@....com>,
	Kamlakant Patel <kamlakant.patel@...adcom.com>,
	Pavel Fedin <p.fedin@...sung.com>, devicetree@...r.kernel.org
Subject: Re: [PATCH 1/3] net: smsc911x: augment device tree bindings

On Fri, Jul 08, 2016 at 11:07:30AM +0200, Linus Walleij wrote:
> This adds device tree bindings for:
> 
> - An optional GPIO line for releasing the RESET signal to the
>   SMSC911x devices
> 
> - An optional PME (power management event) interrupt line that
>   can be utilized to wake up the system on network activity.
>   This signal exist on all the SMSC911x devices, it is just not
>   very often routed.
> 
> Both these lines are routed to the SoC on the Qualcomm APQ8060
> Dragonboard and thus needs to be bound in the device tree.
> 
> Cc: devicetree@...r.kernel.org
> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>
> ---
>  Documentation/devicetree/bindings/net/smsc911x.txt | 16 ++++++++++++----
>  1 file changed, 12 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/smsc911x.txt b/Documentation/devicetree/bindings/net/smsc911x.txt
> index 3fed3c124411..7b01c37272c1 100644
> --- a/Documentation/devicetree/bindings/net/smsc911x.txt
> +++ b/Documentation/devicetree/bindings/net/smsc911x.txt
> @@ -3,9 +3,12 @@
>  Required properties:
>  - compatible : Should be "smsc,lan<model>", "smsc,lan9115"
>  - reg : Address and length of the io space for SMSC LAN
> -- interrupts : Should contain SMSC LAN interrupt line
> -- interrupt-parent : Should be the phandle for the interrupt controller
> -  that services interrupts for this device
> +- interrupts/extended-interrupts : Should contain the SMSC LAN

It's interrupts-extended. Documentation-wise both are always supported, 
so we just document 'interrupts' unless interrupts-extended is only ever 
valid which would not be the case here.

> +  interrupt line as cell 0, cell 1 is an OPTIONAL PME (power
> +  management event) interrupt that is able to wake up the host
> +  system with a 50ms pulse on network activity
> +  For generic bindings for interrupt controller parents, refer to
> +  interrupt-controller/interrupts.txt
>  - phy-mode : See ethernet.txt file in the same directory