netdev - Re: [PATCH 3/3] RFC: net: smsc911x: add wake-up event interrupt support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <578935DE.8090104@gmail.com>
Date:	Fri, 15 Jul 2016 12:13:34 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Linus Walleij <linus.walleij@...aro.org>, netdev@...r.kernel.org,
	"David S . Miller" <davem@...emloft.net>,
	Steve Glendinning <steve.glendinning@...c.com>
Cc:	Guenter Roeck <linux@...ck-us.net>,
	Jeremy Linton <jeremy.linton@....com>,
	Kamlakant Patel <kamlakant.patel@...adcom.com>,
	Pavel Fedin <p.fedin@...sung.com>,
	Sudeep Holla <sudeep.holla@....com>,
	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	Tony Lindgren <tony@...mide.com>,
	"Rafael J . Wysocki" <rjw@...ysocki.net>,
	John Stultz <john.stultz@...aro.org>
Subject: Re: [PATCH 3/3] RFC: net: smsc911x: add wake-up event interrupt
 support

On 07/08/2016 02:07 AM, Linus Walleij wrote:
> +static irqreturn_t smsc911x_pme_irq_thread(int irq, void *dev_id)
> +{
> +	struct net_device *dev = dev_id;
> +	struct smsc911x_data *pdata __maybe_unused = netdev_priv(dev);
> +
> +	SMSC_TRACE(pdata, pm, "wakeup event");
> +	/* This signal is active for 50 ms, wait for it to deassert */
> +	usleep_range(50000, 100000);

Should not you have a call to pm_wakeup_event() such that this probably
gets accounted for as a wake-up event in /sys/*?
-- 
Florian