netdev - Re: [PATCH net-next v2 07/10] net/faraday: Read MAC address from chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160719234007.GA4376@gwshan>
Date:	Wed, 20 Jul 2016 09:40:07 +1000
From:	Gavin Shan <gwshan@...ux.vnet.ibm.com>
To:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:	David Laight <David.Laight@...LAB.COM>,
	"'Gavin Shan'" <gwshan@...ux.vnet.ibm.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"joel@....id.au" <joel@....id.au>,
	"gerlitz.or@...il.com" <gerlitz.or@...il.com>,
	"weixue@...stnetic.com" <weixue@...stnetic.com>,
	"yuvali@...lanox.com" <yuvali@...lanox.com>,
	"alexei.starovoitov@...il.com" <alexei.starovoitov@...il.com>,
	"f.fainelli@...il.com" <f.fainelli@...il.com>
Subject: Re: [PATCH net-next v2 07/10] net/faraday: Read MAC address from chip

On Tue, Jul 19, 2016 at 08:57:53PM +1000, Benjamin Herrenschmidt wrote:
>On Tue, 2016-07-19 at 10:50 +0000, David Laight wrote:
>> > +     if (!is_valid_ether_addr(mac)) {
>> > +             mac[5] = (m >> 8) & 0xff;
>> > +             mac[4] = m & 0xff;
>> > +             mac[3] = (l >> 24) & 0xff;
>> > +             mac[2] = (l >> 16) & 0xff;
>> > +             mac[1] = (l >>  8) & 0xff;
>> > +             mac[0] = l & 0xff;
>> > +     }
>> ...
>> 
>> That is horrid, not all byte reversed addresses will be invalid.
>
>Right, that's just a hack for a broken vendor uboot we had here, Gavin,
>drop that part of the patch please.
>

Sure, I'll drop it in v4 or a followup patch. v3 is being reviewed this
moment.

Thanks,
Gavin