lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20160721005350.GB85017@ast-mbp> Date: Wed, 20 Jul 2016 17:53:55 -0700 From: Alexei Starovoitov <alexei.starovoitov@...il.com> To: Saeed Mahameed <saeedm@...lanox.com> Cc: "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org, Matthew Finlay <matt@...lanox.com> Subject: Re: [PATCH net V2] net/mlx5e: Fix del vxlan port command buffer memset On Thu, Jul 21, 2016 at 12:39:53AM +0300, Saeed Mahameed wrote: > memset the command buffers rather than the pointers to them. that is still wrong commit log. This patch makes zero difference to generated code. '&in' is the same as 'in' > Fixes: b3f63c3d5e2c ("net/mlx5e: Add netdev support for VXLAN tunneling") > Signed-off-by: Saeed Mahameed <saeedm@...lanox.com> > --- > > V2: > - Improved log message. > > drivers/net/ethernet/mellanox/mlx5/core/vxlan.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/vxlan.c b/drivers/net/ethernet/mellanox/mlx5/core/vxlan.c > index 05de772..e25a73ed 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/vxlan.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/vxlan.c > @@ -72,8 +72,8 @@ static int mlx5e_vxlan_core_del_port_cmd(struct mlx5_core_dev *mdev, u16 port) > u32 in[MLX5_ST_SZ_DW(delete_vxlan_udp_dport_in)]; > u32 out[MLX5_ST_SZ_DW(delete_vxlan_udp_dport_out)]; > > - memset(&in, 0, sizeof(in)); > - memset(&out, 0, sizeof(out)); > + memset(in, 0, sizeof(in)); > + memset(out, 0, sizeof(out)); > > MLX5_SET(delete_vxlan_udp_dport_in, in, opcode, > MLX5_CMD_OP_DELETE_VXLAN_UDP_DPORT); > -- > 2.8.0 >
Powered by blists - more mailing lists