netdev - Re: [PATCH net-next 1/3] net/mlx4_en: use READ_ONCE when freeing xdp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160721012036.GB86045@ast-mbp.thefacebook.com>
Date:	Wed, 20 Jul 2016 18:20:37 -0700
From:	Alexei Starovoitov <alexei.starovoitov@...il.com>
To:	Brenden Blanco <bblanco@...mgrid.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	Daniel Borkmann <daniel@...earbox.net>,
	Tariq Toukan <ttoukan.linux@...il.com>
Subject: Re: [PATCH net-next 1/3] net/mlx4_en: use READ_ONCE when freeing
 xdp_prog

On Wed, Jul 20, 2016 at 05:22:33PM -0700, Brenden Blanco wrote:
> For consistency, and in order to hint at the synchronous nature of the
> xdp_prog field, use READ_ONCE in the destroy path of the ring. All
> occurrences should now use either READ_ONCE or xchg.
> 
> Signed-off-by: Brenden Blanco <bblanco@...mgrid.com>

Suggested-by: Daniel Borkmann <daniel@...earbox.net>
Acked-by: Alexei Starovoitov <ast@...nel.org>