netdev - Re: [PATCH net-next 2/3] rtnl: protect do_setlink from IFLA_XDP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160721012152.GC86045@ast-mbp.thefacebook.com>
Date:	Wed, 20 Jul 2016 18:21:52 -0700
From:	Alexei Starovoitov <alexei.starovoitov@...il.com>
To:	Brenden Blanco <bblanco@...mgrid.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	Daniel Borkmann <daniel@...earbox.net>,
	Tariq Toukan <ttoukan.linux@...il.com>
Subject: Re: [PATCH net-next 2/3] rtnl: protect do_setlink from
 IFLA_XDP_ATTACHED

On Wed, Jul 20, 2016 at 05:22:34PM -0700, Brenden Blanco wrote:
> The IFLA_XDP_ATTACHED nested attribute is meant for read-only, and while
> do_setlink properly ignores it, it should be more paranoid and reject
> commands that try to set it.
> 
> Signed-off-by: Brenden Blanco <bblanco@...mgrid.com>

Suggested-by: Daniel Borkmann <daniel@...earbox.net>
Acked-by: Alexei Starovoitov <ast@...nel.org>