netdev - Re: [PATCH v5 10/11] Documentation: dtb: xgene: Add MDIO node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 21 Jul 2016 10:57:59 -0700
From:	Iyappan Subramanian <isubramanian@....com>
To:	Rob Herring <robh@...nel.org>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>, patches <patches@....com>,
	Matthias Brugger <matthias.bgg@...il.com>,
	Andrew Lunn <andrew@...n.ch>,
	Russell King - ARM Linux <linux@...linux.org.uk>
Subject: Re: [PATCH v5 10/11] Documentation: dtb: xgene: Add MDIO node

On Wed, Jul 13, 2016 at 6:10 AM, Rob Herring <robh@...nel.org> wrote:
> On Thu, Jul 07, 2016 at 04:02:58PM -0700, Iyappan Subramanian wrote:
>> Signed-off-by: Iyappan Subramanian <isubramanian@....com>
>> Tested-by: Fushen Chen <fchen@....com>
>> Tested-by: Toan Le <toanle@....com>
>> Tested-by: Matthias Brugger <mbrugger@...e.com>
>> ---
>>  .../devicetree/bindings/net/apm-xgene-mdio.txt     | 37 ++++++++++++++++++++++
>>  1 file changed, 37 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/net/apm-xgene-mdio.txt
>>
>> diff --git a/Documentation/devicetree/bindings/net/apm-xgene-mdio.txt b/Documentation/devicetree/bindings/net/apm-xgene-mdio.txt
>> new file mode 100644
>> index 0000000..0247e70
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/net/apm-xgene-mdio.txt
>> @@ -0,0 +1,37 @@
>> +APM X-Gene SoC MDIO node
>> +
>> +MDIO node is defined to describe on-chip MDIO controller.
>> +
>> +Required properties:
>> +     - compatible: Must be "apm,xgene-mdio-rgmii"
>> +     - #address-cells: Must be <1>.
>> +     - #size-cells: Must be <0>.
>> +     - reg: Address and length of the register set
>> +     - clocks: Reference to the clock entry
>> +
>> +For the phys on the mdio bus, there must be a node with the following fields:
>> +     - compatible: PHY identifier.  Please refer ./phy.txt for the format.
>> +     - reg: The ID number for the phy.
>> +
>> +Example:
>> +
>> +     mdio: mdio@...7020000 {
>
> Drop the '0x'

Thanks for the review.  Corrected and posted v6.

>
> With that,
>
> Acked-by: Rob Herring <robh@...nel.org>
>
>> +             compatible = "apm,xgene-mdio-rgmii";
>> +             #address-cells = <1>;
>> +             #size-cells = <0>;
>> +             reg = <0x0 0x17020000 0x0 0xd100>;
>> +             clocks = <&menetclk 0>;
>> +     };
>> +
>> +     /* Board-specific peripheral configurations */
>> +     &mdio {
>> +             menetphy: phy@3 {
>> +                     reg = <0x3>;
>> +             };
>> +             sgenet0phy: phy@4 {
>> +                     reg = <0x4>;
>> +             };
>> +             sgenet1phy: phy@5 {
>> +                     reg = <0x5>;
>> +             };
>> +     };
>> --
>> 1.9.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe devicetree" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html