netdev - Re: [PATCH net V2] net/mlx5e: Fix del vxlan port command buffer memset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160721174810.GA92690@ast-mbp.thefacebook.com>
Date:	Thu, 21 Jul 2016 10:48:11 -0700
From:	Alexei Starovoitov <alexei.starovoitov@...il.com>
To:	Saeed Mahameed <saeedm@....mellanox.co.il>
Cc:	Saeed Mahameed <saeedm@...lanox.com>,
	"David S. Miller" <davem@...emloft.net>,
	Linux Netdev List <netdev@...r.kernel.org>,
	Matthew Finlay <matt@...lanox.com>
Subject: Re: [PATCH net V2] net/mlx5e: Fix del vxlan port command buffer
 memset

On Thu, Jul 21, 2016 at 11:08:06AM +0300, Saeed Mahameed wrote:
> On Thu, Jul 21, 2016 at 3:53 AM, Alexei Starovoitov
> <alexei.starovoitov@...il.com> wrote:
> > On Thu, Jul 21, 2016 at 12:39:53AM +0300, Saeed Mahameed wrote:
> >> memset the command buffers rather than the pointers to them.
> >
> > that is still wrong commit log.
> > This patch makes zero difference to generated code.
> > '&in' is the same as 'in'
> >
> 
> Who said they are not ? There was a mistake in the original log
> message and it was fixed here.
> The patch was made to make the code consistent with other places in
> the code, and i don't see anything wrong with the log message.

the commit log implies that there is a bug. There is none.
old code does 'memset the command buffers'.
'rather than the pointers' is not correct.