netdev - Re: [PATCH] net: bridge: br_set_ageing_time takes a clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpWCwe11Sc+w5Gi2QFBdwAX0nLUKOtnV-cND4uAAEwEX6w@mail.gmail.com>
Date:	Thu, 21 Jul 2016 11:27:12 -0700
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Cc:	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>, kernel@...oirfairelinux.com,
	"David S. Miller" <davem@...emloft.net>,
	Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH] net: bridge: br_set_ageing_time takes a clock_t

On Thu, Jul 21, 2016 at 11:18 AM, Vivien Didelot
<vivien.didelot@...oirfairelinux.com> wrote:
> Hi Cong,
>
> Cong Wang <xiyou.wangcong@...il.com> writes:
>
>> On Thu, Jul 21, 2016 at 9:42 AM, Vivien Didelot
>> <vivien.didelot@...oirfairelinux.com> wrote:
>>> Change the ageing_time type in br_set_ageing_time() from u32 to what it
>>> is expected to be, i.e. a clock_t.
>>
>> You also need to change struct switchdev_attr:
>>
>> struct switchdev_attr {
>>         struct net_device *orig_dev;
>>         enum switchdev_attr_id id;
>>         u32 flags;
>>         void *complete_priv;
>>         void (*complete)(struct net_device *dev, int err, void *priv);
>>         union {
>>                 struct netdev_phys_item_id ppid;        /* PORT_PARENT_ID */
>>                 u8 stp_state;                           /* PORT_STP_STATE */
>>                 unsigned long brport_flags;             /* PORT_BRIDGE_FLAGS */
>>                 u32 ageing_time;                        /* BRIDGE_AGEING_TIME */
>>                 bool vlan_filtering;                    /*
>> BRIDGE_VLAN_FILTERING */
>>         } u;
>> };
>
> Already changed in net/master as of eabfdda93477
> ("net: switchdev: change ageing_time type to clock_t").

Oh, your are right, sorry I was on net-next.