netdev - Re: [Patch net-next 1/2] net_sched: move tc_action into tcf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 22 Jul 2016 02:35:39 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Cong Wang <xiyou.wangcong@...il.com>
Cc:	kbuild-all@...org, netdev@...r.kernel.org,
	Cong Wang <xiyou.wangcong@...il.com>,
	Jamal Hadi Salim <jhs@...atatu.com>
Subject: Re: [Patch net-next 1/2] net_sched: move tc_action into tcf_common

Hi,

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Cong-Wang/net_sched-refactor-tc-action-structures/20160722-010949
config: sh-titan_defconfig (attached as .config)
compiler: sh4-linux-gnu-gcc (Debian 5.4.0-6) 5.4.0 20160609
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=sh 

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   In file included from include/net/act_api.h:8:0,
                    from net/sched/act_police.c:22:
   net/sched/act_police.c: In function 'tcf_act_police_init':
>> include/net/sch_generic.h:782:16: warning: 'police' may be used uninitialized in this function [-Wmaybe-uninitialized]
     if (unlikely(r->linklayer == TC_LINKLAYER_ATM))
                   ^
   net/sched/act_police.c:125:21: note: 'police' was declared here
     struct tcf_police *police;
                        ^

vim +/police +782 include/net/sch_generic.h

e9bef55d3 Jesper Dangaard Brouer 2007-09-12  766  	return rtab->data[slot];
e9bef55d3 Jesper Dangaard Brouer 2007-09-12  767  }
e9bef55d3 Jesper Dangaard Brouer 2007-09-12  768  
292f1c7ff Jiri Pirko             2013-02-12  769  struct psched_ratecfg {
130d3d68b Eric Dumazet           2013-06-06  770  	u64	rate_bytes_ps; /* bytes per second */
292f1c7ff Jiri Pirko             2013-02-12  771  	u32	mult;
01cb71d2d Eric Dumazet           2013-06-02  772  	u16	overhead;
8a8e3d84b Jesper Dangaard Brouer 2013-08-14  773  	u8	linklayer;
01cb71d2d Eric Dumazet           2013-06-02  774  	u8	shift;
292f1c7ff Jiri Pirko             2013-02-12  775  };
292f1c7ff Jiri Pirko             2013-02-12  776  
292f1c7ff Jiri Pirko             2013-02-12  777  static inline u64 psched_l2t_ns(const struct psched_ratecfg *r,
292f1c7ff Jiri Pirko             2013-02-12  778  				unsigned int len)
292f1c7ff Jiri Pirko             2013-02-12  779  {
8a8e3d84b Jesper Dangaard Brouer 2013-08-14  780  	len += r->overhead;
8a8e3d84b Jesper Dangaard Brouer 2013-08-14  781  
8a8e3d84b Jesper Dangaard Brouer 2013-08-14 @782  	if (unlikely(r->linklayer == TC_LINKLAYER_ATM))
8a8e3d84b Jesper Dangaard Brouer 2013-08-14  783  		return ((u64)(DIV_ROUND_UP(len,48)*53) * r->mult) >> r->shift;
8a8e3d84b Jesper Dangaard Brouer 2013-08-14  784  
8a8e3d84b Jesper Dangaard Brouer 2013-08-14  785  	return ((u64)len * r->mult) >> r->shift;
292f1c7ff Jiri Pirko             2013-02-12  786  }
292f1c7ff Jiri Pirko             2013-02-12  787  
5c15257f9 Joe Perches            2013-07-30  788  void psched_ratecfg_precompute(struct psched_ratecfg *r,
3e1e3aae1 Eric Dumazet           2013-09-19  789  			       const struct tc_ratespec *conf,
3e1e3aae1 Eric Dumazet           2013-09-19  790  			       u64 rate64);

:::::: The code at line 782 was first introduced by commit
:::::: 8a8e3d84b1719a56f9151909e80ea6ebc5b8e318 net_sched: restore "linklayer atm" handling

:::::: TO: Jesper Dangaard Brouer <brouer@...hat.com>
:::::: CC: David S. Miller <davem@...emloft.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (15748 bytes)