netdev - Re: [Patch net-next 1/2] net_sched: move tc_action into tcf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM_iQpUMXAyAUH32tfN4gYShPmEMpJCk1H3beT9FtvhK4cFMaQ@mail.gmail.com>
Date:	Thu, 21 Jul 2016 14:12:06 -0700
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	kbuild test robot <lkp@...el.com>
Cc:	kbuild-all@...org,
	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	Jamal Hadi Salim <jhs@...atatu.com>
Subject: Re: [Patch net-next 1/2] net_sched: move tc_action into tcf_common

On Thu, Jul 21, 2016 at 11:35 AM, kbuild test robot <lkp@...el.com> wrote:
> All warnings (new ones prefixed by >>):
>
>    In file included from include/net/act_api.h:8:0,
>                     from net/sched/act_police.c:22:
>    net/sched/act_police.c: In function 'tcf_act_police_init':
>>> include/net/sch_generic.h:782:16: warning: 'police' may be used uninitialized in this function [-Wmaybe-uninitialized]
>      if (unlikely(r->linklayer == TC_LINKLAYER_ATM))
>                    ^
>    net/sched/act_police.c:125:21: note: 'police' was declared here
>      struct tcf_police *police;

Yeah, I need to move police = to_police(*a); down after the following
goto label.

I will update this patch after waiting for comments from Jamal.