netdev - Re: [PATCH net-next] udp: use sk_filter_trim_cap for udp{,6}_queue_rcv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF=yD-JzDKh_YTA++t0EuRZYiL0Ou_SqOyiTUiqMHovhC85Grg@mail.gmail.com>
Date:	Mon, 25 Jul 2016 12:48:10 -0400
From:	Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:	Daniel Borkmann <daniel@...earbox.net>
Cc:	David Miller <davem@...emloft.net>,
	Network Development <netdev@...r.kernel.org>,
	Alexei Starovoitov <alexei.starovoitov@...il.com>,
	Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net-next] udp: use sk_filter_trim_cap for udp{,6}_queue_rcv_skb

On Mon, Jul 25, 2016 at 12:06 PM, Daniel Borkmann <daniel@...earbox.net> wrote:
> After a612769774a3 ("udp: prevent bugcheck if filter truncates packet
> too much"), there followed various other fixes for similar cases such
> as f4979fcea7fd ("rose: limit sk_filter trim to payload").
>
> Latter introduced a new helper sk_filter_trim_cap(), where we can pass
> the trim limit directly to the socket filter handling. Make use of it
> here as well with sizeof(struct udphdr) as lower cap limit and drop the
> extra skb->len test in UDP's input path.
>
> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>

Acked-by: Willem de Bruijn <willemb@...gle.com>