netdev - Re: [PATCH net-next] udp: use sk_filter_trim_cap for udp{,6}_queue_rcv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160725.214042.2053568298270455930.davem@davemloft.net>
Date:	Mon, 25 Jul 2016 21:40:42 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	daniel@...earbox.net
Cc:	netdev@...r.kernel.org, willemdebruijn.kernel@...il.com,
	alexei.starovoitov@...il.com, willemb@...gle.com
Subject: Re: [PATCH net-next] udp: use sk_filter_trim_cap for
 udp{,6}_queue_rcv_skb

From: Daniel Borkmann <daniel@...earbox.net>
Date: Mon, 25 Jul 2016 18:06:12 +0200

> After a612769774a3 ("udp: prevent bugcheck if filter truncates packet
> too much"), there followed various other fixes for similar cases such
> as f4979fcea7fd ("rose: limit sk_filter trim to payload").
> 
> Latter introduced a new helper sk_filter_trim_cap(), where we can pass
> the trim limit directly to the socket filter handling. Make use of it
> here as well with sizeof(struct udphdr) as lower cap limit and drop the
> extra skb->len test in UDP's input path.
> 
> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>

Applied.