netdev - Re: [PATCH v2] net: davinci_cpdma: remove excessive dump of register values to kernel log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 26 Jul 2016 17:26:39 +0300
From:	Grygorii Strashko <grygorii.strashko@...com>
To:	David Miller <davem@...emloft.net>,
	<u.kleine-koenig@...gutronix.de>,
	Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>
CC:	<mugunthanvnm@...com>, <linux-omap@...r.kernel.org>,
	<netdev@...r.kernel.org>, <kernel@...gutronix.de>
Subject: Re: [PATCH v2] net: davinci_cpdma: remove excessive dump of register
 values to kernel log

+ CC: Ivan

On 07/26/2016 05:09 PM, Grygorii Strashko wrote:
> On 07/26/2016 03:57 AM, David Miller wrote:
>> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
>> Date: Mon, 25 Jul 2016 11:54:45 +0200
>>
>>> Such a big dump of register values is hardly useful on a production
>>> system.
>>>
>>> Another downside of the now removed functions is that calling
>>> emac_dump_regs resulted in at least 87 calls to dev_info while holding a
>>> spinlock and having irqs off which is a big source of latency.
>>>
>>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
>>
>> Applied.
>>
>
> :( To be honest I was really enjoyed using cpdma_ctlr_dump()
> for debug purposed during the past few weeks in cpsw where I've added
> calls to this func manually. And I even thinking about adding debug_fs
> entry for the same :(
>
> Pretty fast merge :(
>
>


-- 
regards,
-grygorii