lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <e2e470ef-b4db-e13e-c9d6-4083a3ad9f2d@linaro.org> Date: Wed, 27 Jul 2016 01:06:55 +0300 From: Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org> To: Grygorii Strashko <grygorii.strashko@...com>, David Miller <davem@...emloft.net>, u.kleine-koenig@...gutronix.de Cc: mugunthanvnm@...com, linux-omap@...r.kernel.org, netdev@...r.kernel.org, kernel@...gutronix.de Subject: Re: [PATCH v2] net: davinci_cpdma: remove excessive dump of register values to kernel log On 26.07.16 17:26, Grygorii Strashko wrote: > + CC: Ivan > > On 07/26/2016 05:09 PM, Grygorii Strashko wrote: >> On 07/26/2016 03:57 AM, David Miller wrote: >>> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de> >>> Date: Mon, 25 Jul 2016 11:54:45 +0200 >>> >>>> Such a big dump of register values is hardly useful on a production >>>> system. >>>> >>>> Another downside of the now removed functions is that calling >>>> emac_dump_regs resulted in at least 87 calls to dev_info while holding a >>>> spinlock and having irqs off which is a big source of latency. >>>> >>>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de> >>> >>> Applied. >>> >> >> :( To be honest I was really enjoyed using cpdma_ctlr_dump() >> for debug purposed during the past few weeks in cpsw where I've added >> calls to this func manually. And I even thinking about adding debug_fs >> entry for the same :( >> >> Pretty fast merge :( At least, partly, for channel stats, for cpsw, I can use ethtool. But ctrl_dump()... the function would be better to leave, redundant calls can be removed from davinci_emac. >> >> > > -- Regards, Ivan Khoronzhuk
Powered by blists - more mailing lists