netdev - Re: [PATCH 1/3] net: asix: Add in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 26 Jul 2016 14:54:32 -0700
From:	Grant Grundler <grundler@...omium.org>
To:	Robert Foss <robert.foss@...labora.com>
Cc:	Grant Grundler <grundler@...omium.org>,
	David Miller <davem@...emloft.net>, Mark_Craske@...tor.com,
	Dean_Jenkins@...tor.com, Vincent Palatin <vpalatin@...omium.org>,
	ivecera@...hat.com, linux@...idrobins.net,
	WK TSAI <wk.tsai@...dia.com>,
	Chia-Sheng Chang <changchias@...il.com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	netdev <netdev@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	enric.balletbo@...labora.com,
	Tomeu Vizoso <tomeu.vizoso@...labora.com>
Subject: Re: [PATCH 1/3] net: asix: Add in_pm parameter

On Tue, Jul 26, 2016 at 2:14 PM, Robert Foss <robert.foss@...labora.com> wrote:
...
> Thanks for the feedback (for this patch and the other ones)!
> I'm preparing a v2 and will submit it withing a day or two.

Excellent! very welcome and thanks again for picking this up.

...
>> FTR, current  drivers/net/usb/ax88179_178a.c uses "in_pm" as well.
>
> Ah! Would you like that to be noted in the commit message?

No - I generally do not muck with commit messages that I didn't write.
It's part of the "finger print" of a patch (so one can trace origin
across distro's and kernel versions).

My comment was intended for reviewers and could be included in the
"comments after the commit message". (ie below the "---" marker in the
patch email).

...
>> BTW, I have two additional changes for AX88772x support sitting in my
>> "needs more work" queue (for quite a while already):
>>    https://chromium-review.googlesource.com/#/c/229620/
>>    "asix: autoneg will set WRITE_MEDIUM reg"
>>
>>    https://chromium-review.googlesource.com/#/c/231162/
>>    "net: asix: see 802.3 spec for phy reset"
>>
>> I would certainly approve if _anyone_ picked these up, tested them,
>> and then submitted them to netdev.
>
> Unfortunately I am without appropriate hardware at the moment.

That's a risky thing to point out for two reasons:

1) I can send you more HW than you could possibly ever use. :)

2) Reviewers of this patch series are already wondering how you
verified the AX88772x patches work on current kernel.org (or
netdev-next) branches.

Please email me with your shipping address (OFFLIST!) and I'll try to
send you some Asix HW to test with.  I'm located in "Silicon Valley"
(USA) and can easily ship in the US. Other countries is a bit harder
and in some cases not possible.

cheers,
grant