netdev - Re: [PATCH net-next V2 0/2] Mellanox 100G mlx5 minimum inline header mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160726.142947.1063145474373793503.davem@davemloft.net>
Date:	Tue, 26 Jul 2016 14:29:47 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	hadarh@....mellanox.co.il
Cc:	saeedm@...lanox.com, netdev@...r.kernel.org, ogerlitz@...lanox.com,
	hadarh@...lanox.com
Subject: Re: [PATCH net-next V2 0/2] Mellanox 100G mlx5 minimum inline
 header mode

From: Hadar Hen Zion <hadarh@....mellanox.co.il>
Date: Tue, 26 Jul 2016 13:30:46 +0300

> In the default case eth_get_headlen() won't be called, it will happen
> only if PF administrator changes the mode from default to L4.
> 
> In L4 mode, we need to copy all the packet headers including L4, do
> you know of a better/cheaper way for doing that?

You can just look straight at the ethernet header in this context.

eth_get_headlen() is expensive and has a complete header parser.  It
is meant to be used when none of the SKB context state has been setup
yet (early RX processing before SKB is allocated, for example).