lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <afdbd734835da306de6859a1495c87d6@mail.gmail.com> Date: Tue, 26 Jul 2016 13:40:54 +0530 From: Sathya Perla <sathya.perla@...adcom.com> To: David Miller <davem@...emloft.net> Cc: netdev@...r.kernel.org Subject: RE: [net-next PATCH 4/4] be2net: replace polling with sleeping in the FW completion path > -----Original Message----- > From: Sathya Perla [mailto:sathya.perla@...adcom.com] > > > -----Original Message----- > > From: David Miller [mailto:davem@...emloft.net] > > > > > @@ -4477,6 +4551,22 @@ static int be_if_create(struct be_adapter > *adapter) > > > u32 cap_flags = be_if_cap_flags(adapter); > > > int status; > > > > > > + /* alloc required memory for other filtering fields */ > > > + adapter->pmac_id = kcalloc(be_max_uc(adapter), > > > + sizeof(*adapter->pmac_id), GFP_KERNEL); > > > + if (!adapter->pmac_id) > > > + return -ENOMEM; > > > + > > > + adapter->mc_list = kcalloc(be_max_mc(adapter), > > > + sizeof(*adapter->mc_list), GFP_KERNEL); > > > + if (!adapter->mc_list) > > > + return -ENOMEM; > > > + > > > + adapter->uc_list = kcalloc(be_max_uc(adapter), > > > + sizeof(*adapter->uc_list), GFP_KERNEL); > > > + if (!adapter->uc_list) > > > + return -ENOMEM; > > > > These error paths are leaking memory, please audit this in the rest of > your change as well. > > David, thanks for catching this; will fix this (and others if any) and > send out a v2. David, actually, when be_if_create() returns an error, it falls back into the error path of be_setup() (the caller) and be_clear() is called. be_clear() calls be_if_destroy() which frees the allocated memory. So, this code will not leak memory in the error path.
Powered by blists - more mailing lists