netdev - Re: [PATCH net-next v2 2/3] bnxt_en: Log a message, if enabling NTUPLE filtering fails.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACKFLinix1aM_YbTMEhN6zX4fR80vKShDebBkTVxD-zk=cXaGg@mail.gmail.com>
Date:	Wed, 27 Jul 2016 01:04:25 -0700
From:	Michael Chan <michael.chan@...adcom.com>
To:	zhuyj <zyjzyj2000@...il.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v2 2/3] bnxt_en: Log a message, if enabling
 NTUPLE filtering fails.

On Wed, Jul 27, 2016 at 12:31 AM, zhuyj <zyjzyj2000@...il.com> wrote:
>  +       if (vnics > pf->max_rsscos_ctxs || vnics > pf->max_vnics) {
>    <-----Does this happen very rarely? If so,
>
> if (unlikely(vnics > pf->max_rsscos_ctxs || vnics > pf->max_vnics) { is better?

This is not in the fast path, so it doesn't matter.

>
> +               netdev_warn(bp->dev,
> +                           "Not enough resources to support NTUPLE
> filters, enough resources for up to %d rx rings\n",
> +                           min(pf->max_rsscos_ctxs - 1, pf->max_vnics - 1));
>                 return false;
> +       }
>