netdev - Re: [PATCH] Networking: Core: netpoll: Fixed a missing spin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160730215836.GA22500@electric-eye.fr.zoreil.com>
Date:	Sat, 30 Jul 2016 23:58:36 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Salil Kapur <salilkapur93@...il.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Networking: Core: netpoll: Fixed a missing spin_unlock

Salil Kapur <salilkapur93@...il.com> :
[...]
> diff --git a/net/core/netpoll.c b/net/core/netpoll.c
> index fc75c9e..9124f76 100644
> --- a/net/core/netpoll.c
> +++ b/net/core/netpoll.c
> @@ -386,8 +386,10 @@ void netpoll_send_skb_on_dev(struct netpoll *np, struct sk_buff *skb,
>  					    !vlan_hw_offload_capable(netif_skb_features(skb),
>  								     skb->vlan_proto)) {
>  						skb = __vlan_put_tag(skb, skb->vlan_proto, vlan_tx_tag_get(skb));
> -						if (unlikely(!skb))
> +						if (unlikely(!skb)) {
> +							__netif_tx_unlock(txq);
>  							break;
> +						}
>  						skb->vlan_tci = 0;
>  					}
>  

Your kernel is outdated: __vlan_put_tag has disappeared from net/core/netpoll.c
since 62749e2cb3c4a7da3eaa5c01a7e787aebeff8536 ("vlan: rename __vlan_put_tag to
vlan_insert_tag_set_proto") by Jiri Pirko somewhere in 2014.

-- 
Ueimor