netdev - Re: [PATCH 1/3] netfilter: nat: update hash bucket if nat changed after ct confirmed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160730222802.GD29291@breakpoint.cc>
Date:	Sun, 31 Jul 2016 00:28:02 +0200
From:	Florian Westphal <fw@...len.de>
To:	fxp2001640163@...il.com
Cc:	pablo@...filter.org, kaber@...sh.net, kadlec@...ckhole.kfki.hu,
	netfilter-devel@...r.kernel.org, coreteam@...filter.org,
	netdev@...r.kernel.org, Xiaoping Fan <xfan@...eaurora.org>
Subject: Re: [PATCH 1/3] netfilter: nat: update hash bucket if nat changed
 after ct confirmed

fxp2001640163@...il.com <fxp2001640163@...il.com> wrote:
> From: Xiaoping Fan <xfan@...eaurora.org>
> 
> In some situations, NAT information is created after connection is
> confirmed.

That sounds like a bug.

How can this happen?

nf_nat_setup_info() is only safe for non-confirmed conntracks
(not in hash table).