netdev - Re: [PATCH 1115/1285] Replace numeric parameter like 0444 with macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 2 Aug 2016 19:47:33 +0200
From:	Pavel Machek <pavel@....cz>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
Cc:	Baole Ni <baolex.ni@...el.com>, pablo@...filter.org,
	kaber@...sh.net, kadlec@...ckhole.kfki.hu, davem@...emloft.net,
	jmorris@...ei.org, yoshfuji@...ux-ipv6.org,
	m.szyprowski@...sung.com, kyungmin.park@...sung.com,
	k.kozlowski@...sung.com, netfilter-devel@...r.kernel.org,
	coreteam@...filter.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, johunt@...mai.com, vpai@...mai.com,
	chuansheng.liu@...el.com, aryabinin@...tuozzo.com
Subject: Re: [PATCH 1115/1285] Replace numeric parameter like 0444 with macro

On Tue 2016-08-02 09:29:27, Eric W. Biederman wrote:
> Baole Ni <baolex.ni@...el.com> writes:
> 
> > I find that the developers often just specified the numeric value
> > when calling a macro which is defined with a parameter for access permission.
> > As we know, these numeric value for access permission have had the corresponding macro,
> > and that using macro can improve the robustness and readability of the code,
> > thus, I suggest replacing the numeric parameter with the macro.
> 
> *Scratches my head*  The permissions are not 0444 below.
> With 1285 patches I wonder how many typos you may have made.
> 
> Was this generated by a script?

I think he got it right:

/usr/include/linux/stat.h:#define S_IRUSR 00400

But that does not make me like the series. And yes, hiding backdoor in
one of those would be way too easy...

									Pavel

> Eric
> 
> > Signed-off-by: Chuansheng Liu <chuansheng.liu@...el.com>
> > Signed-off-by: Baole Ni <baolex.ni@...el.com>
> > ---
> >  net/netfilter/ipset/ip_set_core.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/net/netfilter/ipset/ip_set_core.c b/net/netfilter/ipset/ip_set_core.c
> > index a748b0c..b6c060d3 100644
> > --- a/net/netfilter/ipset/ip_set_core.c
> > +++ b/net/netfilter/ipset/ip_set_core.c
> > @@ -48,7 +48,7 @@ static inline struct ip_set_net *ip_set_pernet(struct net *net)
> >  
> >  static unsigned int max_sets;
> >  
> > -module_param(max_sets, int, 0600);
> > +module_param(max_sets, int, S_IRUSR | S_IWUSR);
> >  MODULE_PARM_DESC(max_sets, "maximal number of sets");
> >  MODULE_LICENSE("GPL");
> >  MODULE_AUTHOR("Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>");

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html