netdev - RE: [PATCH net-next 02/18] liquidio support for new device cn23xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 4 Aug 2016 18:12:56 +0000
From:	Yuval Mintz <Yuval.Mintz@...gic.com>
To:	Raghu Vatsavayi <rvatsavayi@...iumnetworks.com>,
	David Miller <davem@...emloft.net>
CC:	netdev <netdev@...r.kernel.org>,
	Derek Chickles <derek.chickles@...iumnetworks.com>,
	Satanand Burla <satananda.burla@...iumnetworks.com>,
	Felix Manlunas <felix.manlunas@...iumnetworks.com>,
	Raghu Vatsavayi <raghu.vatsavayi@...iumnetworks.com>
Subject: RE: [PATCH net-next  02/18] liquidio support for new device cn23xx

> +		vdata->major =
> cpu_to_be16(LIQUIDIO_BASE_MAJOR_VERSION);
> +		vdata->minor =
> cpu_to_be16(LIQUIDIO_BASE_MINOR_VERSION);
> +		vdata->micro =
> cpu_to_be16(LIQUIDIO_BASE_MICRO_VERSION);
Will probably add sparse warnings.

> +#define LIO_STR_HELPER(x)	#x
> +#define LIO_STR(x)	LIO_STR_HELPER(x)
This is basically __stringify()

> +struct lio_version {
> +	u64  major:16;
> +	u64  minor:16;
> +	u64  micro:16;
> +	u64  reserved:16;
> +};
You probably want those typed, not merely bits out of u64.
But even if you didn't, what's the benefit this has over u16s?