netdev - Re: [PATCH net 2/3] bpf: fix checksum fixups on bpf_skb_store

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201608041148.lftoFao6%fengguang.wu@intel.com>
Date:	Thu, 4 Aug 2016 11:10:57 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Daniel Borkmann <daniel@...earbox.net>
Cc:	kbuild-all@...org, davem@...emloft.net,
	alexei.starovoitov@...il.com, tgraf@...g.ch,
	netdev@...r.kernel.org, Daniel Borkmann <daniel@...earbox.net>
Subject: Re: [PATCH net 2/3] bpf: fix checksum fixups on bpf_skb_store_bytes

Hi Daniel,

[auto build test WARNING on net/master]

url:    https://github.com/0day-ci/linux/commits/Daniel-Borkmann/Few-BPF-helper-related-checksum-fixes/20160804-085300
reproduce: make htmldocs

All warnings (new ones prefixed by >>):

   include/linux/skbuff.h:940: warning: No description found for parameter 'sk'
>> include/linux/skbuff.h:2864: warning: No description found for parameter 'off'
   include/net/sock.h:449: warning: No description found for parameter 'sk_padding'
   include/net/sock.h:449: warning: No description found for parameter 'sk_rcu'
   include/linux/netdevice.h:1889: warning: No description found for parameter 'prio_tc_map[TC_BITMASK + 1]'

vim +/off +2864 include/linux/skbuff.h

^1da177e Linus Torvalds  2005-04-16  2848  }
^1da177e Linus Torvalds  2005-04-16  2849  
^1da177e Linus Torvalds  2005-04-16  2850  /**
^1da177e Linus Torvalds  2005-04-16  2851   *	skb_postpull_rcsum - update checksum for received skb after pull
^1da177e Linus Torvalds  2005-04-16  2852   *	@skb: buffer to update
^1da177e Linus Torvalds  2005-04-16  2853   *	@start: start of data before pull
^1da177e Linus Torvalds  2005-04-16  2854   *	@len: length of data pulled
^1da177e Linus Torvalds  2005-04-16  2855   *
^1da177e Linus Torvalds  2005-04-16  2856   *	After doing a pull on a received packet, you need to call this to
84fa7933 Patrick McHardy 2006-08-29  2857   *	update the CHECKSUM_COMPLETE checksum, or set ip_summed to
84fa7933 Patrick McHardy 2006-08-29  2858   *	CHECKSUM_NONE so that it can be recomputed from scratch.
^1da177e Linus Torvalds  2005-04-16  2859   */
^1da177e Linus Torvalds  2005-04-16  2860  
1716d701 Daniel Borkmann 2016-08-04  2861  static __always_inline void
1716d701 Daniel Borkmann 2016-08-04  2862  __skb_postpull_rcsum(struct sk_buff *skb, const void *start, unsigned int len,
1716d701 Daniel Borkmann 2016-08-04  2863  		     unsigned int off)
^1da177e Linus Torvalds  2005-04-16 @2864  {
84fa7933 Patrick McHardy 2006-08-29  2865  	if (skb->ip_summed == CHECKSUM_COMPLETE)
1716d701 Daniel Borkmann 2016-08-04  2866  		skb->csum = csum_block_sub(skb->csum,
1716d701 Daniel Borkmann 2016-08-04  2867  					   csum_partial(start, len, 0), off);
6ae459bd Pravin B Shelar 2015-09-22  2868  	else if (skb->ip_summed == CHECKSUM_PARTIAL &&
31b33dfb Pravin B Shelar 2015-09-28  2869  		 skb_checksum_start_offset(skb) < 0)
6ae459bd Pravin B Shelar 2015-09-22  2870  		skb->ip_summed = CHECKSUM_NONE;
^1da177e Linus Torvalds  2005-04-16  2871  }
^1da177e Linus Torvalds  2005-04-16  2872  

:::::: The code at line 2864 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds@...970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@...970.osdl.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (6353 bytes)