netdev - Re: [PATCH net 2/3] bpf: fix checksum fixups on bpf_skb_store

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <57A2FC74.7040701@iogearbox.net>
Date:	Thu, 04 Aug 2016 10:27:32 +0200
From:	Daniel Borkmann <daniel@...earbox.net>
To:	kbuild test robot <lkp@...el.com>
CC:	kbuild-all@...org, davem@...emloft.net,
	alexei.starovoitov@...il.com, tgraf@...g.ch, netdev@...r.kernel.org
Subject: Re: [PATCH net 2/3] bpf: fix checksum fixups on bpf_skb_store_bytes

On 08/04/2016 05:10 AM, kbuild test robot wrote:
> Hi Daniel,
>
> [auto build test WARNING on net/master]
>
> url:    https://github.com/0day-ci/linux/commits/Daniel-Borkmann/Few-BPF-helper-related-checksum-fixes/20160804-085300
> reproduce: make htmldocs
>
> All warnings (new ones prefixed by >>):
>
>     include/linux/skbuff.h:940: warning: No description found for parameter 'sk'
>>> include/linux/skbuff.h:2864: warning: No description found for parameter 'off'
>     include/net/sock.h:449: warning: No description found for parameter 'sk_padding'
>     include/net/sock.h:449: warning: No description found for parameter 'sk_rcu'
>     include/linux/netdevice.h:1889: warning: No description found for parameter 'prio_tc_map[TC_BITMASK + 1]'
>
> vim +/off +2864 include/linux/skbuff.h
>
> ^1da177e Linus Torvalds  2005-04-16  2848  }
> ^1da177e Linus Torvalds  2005-04-16  2849
> ^1da177e Linus Torvalds  2005-04-16  2850  /**
> ^1da177e Linus Torvalds  2005-04-16  2851   *	skb_postpull_rcsum - update checksum for received skb after pull
> ^1da177e Linus Torvalds  2005-04-16  2852   *	@skb: buffer to update
> ^1da177e Linus Torvalds  2005-04-16  2853   *	@start: start of data before pull
> ^1da177e Linus Torvalds  2005-04-16  2854   *	@len: length of data pulled
> ^1da177e Linus Torvalds  2005-04-16  2855   *
> ^1da177e Linus Torvalds  2005-04-16  2856   *	After doing a pull on a received packet, you need to call this to
> 84fa7933 Patrick McHardy 2006-08-29  2857   *	update the CHECKSUM_COMPLETE checksum, or set ip_summed to
> 84fa7933 Patrick McHardy 2006-08-29  2858   *	CHECKSUM_NONE so that it can be recomputed from scratch.
> ^1da177e Linus Torvalds  2005-04-16  2859   */

Alright, I move the kdoc under skb_postpull_rcsum() and also add one for
skb_postpush_rcsum() in a v2 of this set. I didn't touch it because of -net
tree, but since someone might be using 'make htmldocs' it shouldn't generate
additional warnings. So, will respin with v2!