netdev - Re: [PATCH] VSOCK: fix vhost virtio_vsock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160805084435.GB15955@stefanha-x1.localdomain>
Date:	Fri, 5 Aug 2016 09:44:35 +0100
From:	Stefan Hajnoczi <stefanha@...hat.com>
To:	"Michael S. Tsirkin" <mst@...hat.com>
Cc:	kvm@...r.kernel.org, netdev@...r.kernel.org,
	Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [PATCH] VSOCK: fix vhost virtio_vsock_pkt use-after-free

On Thu, Aug 04, 2016 at 07:34:43PM +0300, Michael S. Tsirkin wrote:
> On Thu, Aug 04, 2016 at 02:52:53PM +0100, Stefan Hajnoczi wrote:
> > Stash the packet length in a local variable before handing over
> > ownership of the packet to virtio_transport_recv_pkt() or
> > virtio_transport_free_pkt().
> > 
> > This patch solves the use-after-free since pkt is no longer guaranteed
> > to be alive.
> > 
> > Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> > Signed-off-by: Stefan Hajnoczi <stefanha@...hat.com>
> 
> 
> Thanks!
> I'd prefer a lower-case prefix, mentioning vhost, such as vhost/vsock.
> I'll tweak it for now.

Thanks, I will use vhost/vsock in the future.

Stefan

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)