netdev - Aw: [PATCH] [v8] net: emac: emac gigabit ethernet controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <trinity-1978b11f-5ee9-4e10-b88d-ab126cd976e0-1471033378842@3capp-gmx-bs27>
Date:	Fri, 12 Aug 2016 22:22:58 +0200
From:	"Lino Sanfilippo" <LinoSanfilippo@....de>
To:	"Timur Tabi" <timur@...eaurora.org>
Cc:	netdev@...r.kernel.org, devicetree@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, sdharia@...eaurora.org,
	shankerd@...eaurora.org, vikrams@...eaurora.org,
	cov@...eaurora.org, gavidov@...eaurora.org, robh+dt@...nel.org,
	andrew@...n.ch, bjorn.andersson@...aro.org, mlangsdo@...hat.com,
	jcm@...hat.com, agross@...eaurora.org, davem@...emloft.net,
	f.fainelli@...il.com
Subject: Aw: [PATCH] [v8] net: emac: emac gigabit ethernet controller driver

Hi,

I really dont want to be a killjoy, but...

> +		int ret;
> +
> +		skb = __netdev_alloc_skb_ip_align(adpt->netdev,
> +						  adpt->rxbuf_size, GFP_KERNEL);

This is also called in softirq context by the napi handler in which GFP_KERNEL is
not allowed.
You can either extend the refill function by one gfp_t parameter and then call it 
with GFP_KERNEL for the initial rx buffer allocation when the hw is brought up and 
then with GFP_ATOMIC for refilling in the NAPI handler. Or simply always use GFP_ATOMIC.
In the latter case the additional parameter is not needed of course and you can
use netdev_alloc_skb_ip_align() instead of __netdev_alloc_skb_ip_align().

Regards,
Lino