netdev - Re: Aw: [PATCH] [v8] net: emac: emac gigabit ethernet controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57AE33FB.5080905@codeaurora.org>
Date:	Fri, 12 Aug 2016 15:39:23 -0500
From:	Timur Tabi <timur@...eaurora.org>
To:	Lino Sanfilippo <LinoSanfilippo@....de>
Cc:	netdev@...r.kernel.org, devicetree@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, sdharia@...eaurora.org,
	shankerd@...eaurora.org, vikrams@...eaurora.org,
	cov@...eaurora.org, gavidov@...eaurora.org, robh+dt@...nel.org,
	andrew@...n.ch, bjorn.andersson@...aro.org, mlangsdo@...hat.com,
	jcm@...hat.com, agross@...eaurora.org, davem@...emloft.net,
	f.fainelli@...il.com
Subject: Re: Aw: [PATCH] [v8] net: emac: emac gigabit ethernet controller
 driver

Lino Sanfilippo wrote:
> You can either extend the refill function by one gfp_t parameter and then call it
> with GFP_KERNEL for the initial rx buffer allocation when the hw is brought up and
> then with GFP_ATOMIC for refilling in the NAPI handler. Or simply always use GFP_ATOMIC.
> In the latter case the additional parameter is not needed of course and you can
> use netdev_alloc_skb_ip_align() instead of __netdev_alloc_skb_ip_align().

I will change this to use netdev_alloc_skb_ip_align().

Thanks.

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.