netdev - Re: Fw: Linux tcp_xmit_retransmit_queue use after free on 4.8-rc1 / master]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFkTriKbQz43Mt7wtHPTzkeszTUvKqCGOLmgCWVikNYnMC_New@mail.gmail.com>
Date:	Wed, 17 Aug 2016 19:10:15 +0800
From:	Marco Grassi <marco.gra@...il.com>
To:	Cong Wang <xiyou.wangcong@...il.com>
Cc:	Eric Dumazet <eric.dumazet@...il.com>,
	Greg KH <gregkh@...uxfoundation.org>,
	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	Yuchung Cheng <ycheng@...gle.com>,
	Neal Cardwell <ncardwell@...gle.com>
Subject: Re: Fw: Linux tcp_xmit_retransmit_queue use after free on 4.8-rc1 / master]

Hello, I'm fuzzing with your patch applied, and I don't see the issue
triggering anymore, (or other related)

I will keep you updated if something pops up, so we can fix before pushing

Marco

On Wed, Aug 17, 2016 at 4:32 AM, Cong Wang <xiyou.wangcong@...il.com> wrote:
> On Tue, Aug 16, 2016 at 1:27 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
>> And tcp_add_write_queue_tail() looks like :
>>
>>
>> static inline void tcp_add_write_queue_tail(struct sock *sk, struct sk_buff *skb)
>> {
>>         __tcp_add_write_queue_tail(sk, skb);
>>
>>         /* Queue it, remembering where we must start sending. */
>>         if (sk->sk_send_head == NULL) {
>>                 sk->sk_send_head = skb;
>>
>>                 if (tcp_sk(sk)->highest_sack == NULL)
>>                         tcp_sk(sk)->highest_sack = skb;
>>         }
>> }
>>
>
> Ah, I never looked into tcp_add_write_queue_tail()...
>
> So this bug seems exist after commit 6859d49475d4f32abe640372117e4b...