[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CACna6rw1j3myPEkbn+YR71W7CF7Of_yahn9eDT7t3hKWGmWUmg@mail.gmail.com>
Date: Wed, 17 Aug 2016 13:34:15 +0200
From: Rafał Miłecki <zajec5@...il.com>
To: Jon Mason <jon.mason@...adcom.com>
Cc: David Miller <davem@...emloft.net>,
Florian Fainelli <f.fainelli@...il.com>,
Hauke Mehrtens <hauke@...ke-m.de>,
Rob Herring <robh+dt@...nel.org>,
Pawel Moll <pawel.moll@....com>,
Mark Rutland <mark.rutland@....com>,
Ian Campbell <ijc+devicetree@...lion.org.uk>,
Kumar Gala <galak@...eaurora.org>, Ray Jui <rjui@...adcom.com>,
Scott Branden <sbranden@...adcom.com>,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@...adcom.com>,
Network Development <netdev@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 4/6] net: ethernet: bgmac: convert to feature flags
On 8 July 2016 at 01:08, Jon Mason <jon.mason@...adcom.com> wrote:
> mode = (bgmac_read(bgmac, BGMAC_DEV_STATUS) & BGMAC_DS_MM_MASK) >>
> BGMAC_DS_MM_SHIFT;
> - if (ci->id != BCMA_CHIP_ID_BCM47162 || mode != 0)
> + if (bgmac->feature_flags & BGMAC_FEAT_CLKCTLST || mode != 0)
> bgmac_set(bgmac, BCMA_CLKCTLST, BCMA_CLKCTLST_FORCEHT);
> - if (ci->id == BCMA_CHIP_ID_BCM47162 && mode == 2)
> + if (bgmac->feature_flags & BGMAC_FEAT_CLKCTLST && mode == 2)
> bcma_chipco_chipctl_maskset(&bgmac->core->bus->drv_cc, 1, ~0,
> BGMAC_CHIPCTL_1_RXC_DLL_BYPASS);
Jon, it looks to me you translated two following conditions:
ci->id != BCMA_CHIP_ID_BCM47162
and
ci->id == BCMA_CHIP_ID_BCM47162
into the same flag check:
bgmac->feature_flags & BGMAC_FEAT_CLKCTLST
I don't think it's intentional, is it? Do you have a moment to fix this?
Powered by blists - more mailing lists