netdev - Re: [PATCH] net: ipv6: Remove addresses for failures with strict DAD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <58750abf-9221-f2d3-0fb2-cc5f1bcd92f9@stressinduktion.org>
Date:	Wed, 17 Aug 2016 17:40:31 +0200
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	Mike Manning <mmanning@...cade.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] net: ipv6: Remove addresses for failures with strict DAD

On 17.08.2016 12:28, Mike Manning wrote:
> +static void dev_disable_change(struct inet6_dev *idev);
>  
>  /*
>   *	Configured unicast address hash table
> @@ -1945,6 +1946,12 @@ lock_errdad:
>  
>  			pr_info("%s: IPv6 being disabled!\n",
>  				ifp->idev->dev->name);
> +			spin_unlock_bh(&ifp->lock);
> +			addrconf_dad_stop(ifp, 1);
> +			rtnl_lock();
> +			dev_disable_change(idev);
> +			rtnl_unlock();
> +			return;
>  		}
>  	}

You can't take rtnl_lock at that point but must postpone the actions and
do that in addrconf_dad_work.

Probably the whole ... else if (idev->cnf.accept_dad > 1 && ...) needs
to move there.

Bye,
Hannes