netdev - Re: [PATCH] net: ipv6: Remove addresses for failures with strict DAD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ae4a3e5a-1b36-5eab-da03-d6121abb6223@brocade.com>
Date:	Wed, 17 Aug 2016 17:08:42 +0100
From:	Mike Manning <mmanning@...cade.com>
To:	Hannes Frederic Sowa <hannes@...essinduktion.org>,
	<netdev@...r.kernel.org>
Subject: Re: [PATCH] net: ipv6: Remove addresses for failures with strict DAD

On 08/17/2016 04:40 PM, Hannes Frederic Sowa wrote:
> On 17.08.2016 12:28, Mike Manning wrote:
>> +static void dev_disable_change(struct inet6_dev *idev);
>>  
>>  /*
>>   *	Configured unicast address hash table
>> @@ -1945,6 +1946,12 @@ lock_errdad:
>>  
>>  			pr_info("%s: IPv6 being disabled!\n",
>>  				ifp->idev->dev->name);
>> +			spin_unlock_bh(&ifp->lock);
>> +			addrconf_dad_stop(ifp, 1);
>> +			rtnl_lock();
>> +			dev_disable_change(idev);
>> +			rtnl_unlock();
>> +			return;
>>  		}
>>  	}
> 
> You can't take rtnl_lock at that point but must postpone the actions and
> do that in addrconf_dad_work.
> 
> Probably the whole ... else if (idev->cnf.accept_dad > 1 && ...) needs
> to move there.
> 
> Bye,
> Hannes
> 
> 

Thanks for the prompt review, I will look into making these changes.

Also these changes caused a build error due to conditional compilation without CONFIG_SYSCTL, which is resolved by replacing the call to dev_disable_change(idev) by directly calling addrconf_ifdown(idev->dev, 0) instead.

I would appreciate any further comments if the suggested change in behavior is not acceptable.

Thanks
Mike