netdev - Re: [RFC PATCH 11/13] net: sched: pfifo_fast use alf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160819121303.50963024@redhat.com>
Date:   Fri, 19 Aug 2016 12:13:03 +0200
From:   Jesper Dangaard Brouer <brouer@...hat.com>
To:     John Fastabend <john.fastabend@...il.com>
Cc:     xiyou.wangcong@...il.com, jhs@...atatu.com,
        alexei.starovoitov@...il.com, eric.dumazet@...il.com,
        john.r.fastabend@...el.com, netdev@...r.kernel.org,
        davem@...emloft.net, brouer@...hat.com,
        "Michael S. Tsirkin" <mst@...hat.com>
Subject: Re: [RFC PATCH 11/13] net: sched: pfifo_fast use alf_queue

On Wed, 17 Aug 2016 12:38:10 -0700
John Fastabend <john.fastabend@...il.com> wrote:

> This converts the pfifo_fast qdisc to use the alf_queue enqueue and
                                                ^^^^^^^^^
> dequeue routines then sets the NOLOCK bit.
> 
> This also removes the logic used to pick the next band to dequeue from
> and instead just checks each alf_queue for packets from top priority
                               ^^^^^^^^^
> to lowest. This might need to be a bit more clever but seems to work
> for now.

You need to fix the description, as you are no longer using my
alf_queue implementation but instead are using the skb_array/ptr_ring
queue (by MST).

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  Author of http://www.iptv-analyzer.org
  LinkedIn: http://www.linkedin.com/in/brouer