netdev - Re: [RFC PATCH 11/13] net: sched: pfifo_fast use alf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57B72971.4020000@gmail.com>
Date:   Fri, 19 Aug 2016 08:44:49 -0700
From:   John Fastabend <john.fastabend@...il.com>
To:     Jesper Dangaard Brouer <brouer@...hat.com>
Cc:     xiyou.wangcong@...il.com, jhs@...atatu.com,
        alexei.starovoitov@...il.com, eric.dumazet@...il.com,
        john.r.fastabend@...el.com, netdev@...r.kernel.org,
        davem@...emloft.net, "Michael S. Tsirkin" <mst@...hat.com>
Subject: Re: [RFC PATCH 11/13] net: sched: pfifo_fast use alf_queue

On 16-08-19 03:13 AM, Jesper Dangaard Brouer wrote:
> On Wed, 17 Aug 2016 12:38:10 -0700
> John Fastabend <john.fastabend@...il.com> wrote:
> 
>> This converts the pfifo_fast qdisc to use the alf_queue enqueue and
>                                                 ^^^^^^^^^
>> dequeue routines then sets the NOLOCK bit.
>>
>> This also removes the logic used to pick the next band to dequeue from
>> and instead just checks each alf_queue for packets from top priority
>                                ^^^^^^^^^
>> to lowest. This might need to be a bit more clever but seems to work
>> for now.
> 
> You need to fix the description, as you are no longer using my
> alf_queue implementation but instead are using the skb_array/ptr_ring
> queue (by MST).
> 

Yep I forgot to change this even though iirc you may have had the same
comment in the last rev. Thanks! I'll get it fixed up this time.

.John