netdev - Re: [PATCH v1 1/1] l2tp: Use existing macros instead of literal number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160819.143202.85723375204268037.davem@davemloft.net>
Date:   Fri, 19 Aug 2016 14:32:02 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     fgao@...ai8.com
Cc:     jchapman@...alix.com, netdev@...r.kernel.org, gfree.wind@...il.com
Subject: Re: [PATCH v1 1/1] l2tp: Use existing macros instead of literal
 number

From: fgao@...ai8.com
Date: Thu, 18 Aug 2016 15:05:19 +0800

> @@ -138,6 +138,8 @@ static const struct ppp_channel_ops pppol2tp_chan_ops = {
>  
>  static const struct proto_ops pppol2tp_ops;
>  
> +static const unsigned char fixed_ppphdr[2] = {PPP_ALLSTATIONS, PPP_UI};
> +
>  /* Helpers to obtain tunnel/session contexts from sockets.
>   */
>  static inline struct l2tp_session *pppol2tp_sock_to_session(struct sock *sk)

Same problem as the pptp patch, I'm not applying this.