netdev - Re: [PATCH v1 1/2] pptp: Use macro and sizeof instead of literal number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160819.143128.561754527412577407.davem@davemloft.net>
Date:   Fri, 19 Aug 2016 14:31:28 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     fgao@...ai8.com
Cc:     xeb@...l.ru, philipp@...fish-solutions.com, netdev@...r.kernel.org,
        gfree.wind@...il.com
Subject: Re: [PATCH v1 1/2] pptp: Use macro and sizeof instead of literal
 number

From: fgao@...ai8.com
Date: Thu, 18 Aug 2016 12:47:34 +0800

> @@ -54,6 +54,8 @@ static struct proto pptp_sk_proto __read_mostly;
>  static const struct ppp_channel_ops pptp_chan_ops;
>  static const struct proto_ops pptp_ops;
>  
> +static const u8 fixed_ppphdr[2] = {PPP_ALLSTATIONS, PPP_UI};
> +

This makes things much worse in my opinion, and at the cost
of two extra bytes in the data section as well.

I'm not applying this.