netdev - Re: [PATCH -next] net: phy: Add missing of_node_put() in xgmiitorgmii

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160820173605.GE30224@lunn.ch>
Date:   Sat, 20 Aug 2016 19:36:05 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Wei Yongjun <weiyj.lk@...il.com>
Cc:     f.fainelli@...il.com, michal.simek@...inx.com,
        soren.brinkmann@...inx.com, netdev@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH -next] net: phy: Add missing of_node_put() in
 xgmiitorgmii_probe()

On Sat, Aug 20, 2016 at 03:26:55PM +0000, Wei Yongjun wrote:
> This node pointer is returned by of_parse_phandle() with
> refcount incremented in this function. of_node_put() on it
> before exitting this function.

Hi Wei

You are only releasing on the error path. What about the successful
path?

	Andrew

> 
> This is detected by Coccinelle semantic patch.
> 
> Signed-off-by: Wei Yongjun <weiyj.lk@...il.com>
> ---
>  drivers/net/phy/xilinx_gmii2rgmii.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/phy/xilinx_gmii2rgmii.c b/drivers/net/phy/xilinx_gmii2rgmii.c
> index cad6e19..4f05e5e 100644
> --- a/drivers/net/phy/xilinx_gmii2rgmii.c
> +++ b/drivers/net/phy/xilinx_gmii2rgmii.c
> @@ -75,6 +75,7 @@ int xgmiitorgmii_probe(struct mdio_device *mdiodev)
>  	priv->phy_dev = of_phy_find_device(phy_node);
>  	if (!priv->phy_dev) {
>  		dev_info(dev, "Couldn't find phydev\n");
> +		of_node_put(phy_node);
>  		return -EPROBE_DEFER;
>  	}
>