netdev - Re: [PATCH -next] net: phy: Add missing of_node_put() in xgmiitorgmii

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160821.152915.360184359793857112.davem@davemloft.net>
Date:   Sun, 21 Aug 2016 15:29:15 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     andrew@...n.ch
Cc:     weiyj.lk@...il.com, f.fainelli@...il.com, michal.simek@...inx.com,
        soren.brinkmann@...inx.com, netdev@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH -next] net: phy: Add missing of_node_put() in
 xgmiitorgmii_probe()

From: Andrew Lunn <andrew@...n.ch>
Date: Sat, 20 Aug 2016 19:36:05 +0200

> On Sat, Aug 20, 2016 at 03:26:55PM +0000, Wei Yongjun wrote:
>> This node pointer is returned by of_parse_phandle() with
>> refcount incremented in this function. of_node_put() on it
>> before exitting this function.
> 
> Hi Wei
> 
> You are only releasing on the error path. What about the successful
> path?

Agreed, as far as I can tell we do need to release it unconditionally
here.