netdev - Re: [PATCH 3/4] dsa: mv88e6xxx: Delete ppu timer when removing module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zio47t7s.fsf@ketchup.mtl.sfl>
Date:   Mon, 22 Aug 2016 10:51:03 -0400
From:   Vivien Didelot <vivien.didelot@...oirfairelinux.com>
To:     Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net>
Cc:     Jamie Lentin <jm@...tin.co.uk>,
        Florian Fainelli <f.fainelli@...il.com>,
        netdev <netdev@...r.kernel.org>, Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH 3/4] dsa: mv88e6xxx: Delete ppu timer when removing module

Hi Andrew,

Andrew Lunn <andrew@...n.ch> writes:

> The PPU method of accessing PHYs makes use of a timer. Make sure this
> timer is deleted before unloading the driver.
>
> Reported-by: Jamie Lentin <jm@...tin.co.uk>
> Signed-off-by: Andrew Lunn <andrew@...n.ch>

I'm wondering if the PPU shouldn't be disabled before unloading the
module... Otherwise:

Reviewed-by: Vivien Didelot <vivien.didelot@...oirfairelinux.com>

Thanks,

        Vivien