netdev - Re: [PATCH 0/4] Fix MV88E6131 tagging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1608221529480.19980@marmot.wormnet.eu>
Date:   Mon, 22 Aug 2016 15:36:29 +0100 (BST)
From:   Jamie Lentin <jm@...tin.co.uk>
To:     Andrew Lunn <andrew@...n.ch>
cc:     David Miller <davem@...emloft.net>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vivien Didelot <vivien.didelot@...oirfairelinux.com>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH 0/4] Fix MV88E6131 tagging

On Mon, 22 Aug 2016, Andrew Lunn wrote:

> Marvell has two different tagging protocols for frames passed to a
> swicth. There is the older DSA and the newer EDSA. Somewhere along the
> way, we broke support for switches which only support DSA, by trying
> to configure them to use EDSA. These patches add back support for
> switches which only support DSA, by allowing the drivers to
> dynamically indicate the tagging protocol they support to the DSA
> core. This needs to be dynamic since the mv88e6xxx has to support two
> protocols.
>
> Thanks go to Jamie Lentin for reporting the problem, helping debug it,
> providing some of the fix, and testing.

Entire series tested on a Netgear WNR854T With a mv88e6131 switch chip.

Tested-By: Jamie Lentin <jm@...tin.co.uk>

> Andrew Lunn (3):
>  net: dsa: Allow the DSA driver to indicate the tag protocol
>  net: dsa: mv88e6xxx: Fix support for DSA tagging for older switches.
>  dsa: mv88e6xxx: Delete ppu timer when removing module
>
> Jamie Lentin (1):
>  net: mv88e6xxx: Enable PORT_CONTROL_FORWARD_UNKNOWN for DSA-tagged CPU
>    ports
>
> drivers/net/dsa/b53/b53_common.c      |  7 +++-
> drivers/net/dsa/bcm_sf2.c             |  7 +++-
> drivers/net/dsa/mv88e6060.c           |  7 +++-
> drivers/net/dsa/mv88e6xxx/Kconfig     |  1 +
> drivers/net/dsa/mv88e6xxx/chip.c      | 61 +++++++++++++++++++++--------------
> drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 16 +++++++--
> include/net/dsa.h                     |  5 +--
> net/dsa/dsa.c                         |  5 ++-
> net/dsa/dsa2.c                        |  4 ++-
> 9 files changed, 78 insertions(+), 35 deletions(-)
>
>

-- 
Jamie Lentin