netdev - RE: [PATCH net-next V3 11/18] liquidio: link and control commands

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO2PR11MB00888B8EE6F66D0B1E8C58E697E80@CO2PR11MB0088.namprd11.prod.outlook.com>
Date:   Mon, 22 Aug 2016 16:15:53 +0000
From:   Yuval Mintz <Yuval.Mintz@...gic.com>
To:     Raghu Vatsavayi <rvatsavayi@...iumnetworks.com>,
        David Miller <davem@...emloft.net>
CC:     netdev <netdev@...r.kernel.org>,
        Derek Chickles <derek.chickles@...iumnetworks.com>,
        Satanand Burla <satananda.burla@...iumnetworks.com>,
        Felix Manlunas <felix.manlunas@...iumnetworks.com>,
        Raghu Vatsavayi <raghu.vatsavayi@...iumnetworks.com>
Subject: RE: [PATCH net-next V3 11/18] liquidio: link and control commands

> +static inline void setup_link_status_change_wq(struct net_device *netdev)
> +{
> +	struct lio *lio = GET_LIO(netdev);
> +	struct octeon_device *oct = lio->oct_dev;
> +
> +	lio->link_status_wq.wq = alloc_workqueue("link-status",
> +						 WQ_MEM_RECLAIM, 0);
> +	if (!lio->link_status_wq.wq) {
> +		dev_err(&oct->pci_dev->dev, "unable to create cavium link
> status wq\n");
> +		return;
> +	}
> +	INIT_DELAYED_WORK(&lio->link_status_wq.wk.work,
> +			  octnet_link_status_change);
> +	lio->link_status_wq.wk.ctxptr = lio;
> +}

Don't you need to propagate the allocation failure?
Won't this wouldn't you still try to schedule the non-initialized workitem
on the non-existent workqueue later on?