netdev - RE: [PATCH net-next V3 16/18] liquidio: CN23XX health monitoring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 22 Aug 2016 16:53:50 +0000
From:   Yuval Mintz <Yuval.Mintz@...gic.com>
To:     Raghu Vatsavayi <rvatsavayi@...iumnetworks.com>,
        David Miller <davem@...emloft.net>
CC:     netdev <netdev@...r.kernel.org>,
        Derek Chickles <derek.chickles@...iumnetworks.com>,
        Satanand Burla <satananda.burla@...iumnetworks.com>,
        Felix Manlunas <felix.manlunas@...iumnetworks.com>,
        Raghu Vatsavayi <raghu.vatsavayi@...iumnetworks.com>
Subject: RE: [PATCH net-next V3 16/18] liquidio: CN23XX health monitoring

> +				/* look at watchdog state field */
> +				wdog &= 12ULL;
Magic value? Probably could use a define.

> +				if (core_is_stuck[core_num] == 1) {
> +					dev_err(&oct->pci_dev->dev,
> +						"ERROR: Octeon core %d is
> stuck!\n",
> +						core_num);
> +					core_is_stuck[core_num] =
> +						2; /* 2 means we have printk'd
> +						    * an error; so no need to
> +						    * repeat the same printk
> +						    */
Likewise.


> +		if (!(scratch1 & 4ULL)) {
> +			/* Bit 2 of SLI_SCRATCH_1 is a flag that indicates that
> +			 * the lio watchdog kernel thread is running for this
> +			 * NIC.  Each NIC gets one watchdog kernel thread.
> +			 */
> +			scratch1 |= 4ULL;
Likewise.