netdev - Re: [PATCH net v2 8/9] net: ethernet: mediatek: use devm_mdiobus_alloc instead of mdiobus_alloc inside mtk_mdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 29 Aug 2016 15:06:28 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     sean.wang@...iatek.com
Cc:     john@...ozen.org, davem@...emloft.net, nbd@...nwrt.org,
        netdev@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        keyhaede@...il.com
Subject: Re: [PATCH net v2 8/9] net: ethernet: mediatek: use
 devm_mdiobus_alloc instead of mdiobus_alloc inside mtk_mdio_init

On Mon, Aug 29, 2016 at 01:03:22PM +0800, sean.wang@...iatek.com wrote:
> From: Sean Wang <sean.wang@...iatek.com>
> 
> a lot of parts in the driver uses devm_* APIs to gain benefits from the
> device resource management, so devm_mdiobus_alloc is also used instead
> of mdiobus_alloc to have more elegant code flow.
> 
> Using common code provided by the devm_* helps to
> 1) have simplified the code flow as [1] says
> 2) decrease the risk of incorrect error handling by human
> 3) only a few drivers used it since it ware proposed on linux 3.16,
> so just hope to promote for this.
> 
> Signed-off-by: Sean Wang <sean.wang@...iatek.com>
> 
> ---
> ref.
> [1] https://patchwork.ozlabs.org/patch/344093/
> ---

Hi Sean

Your footnote is below the ---, so won't make it into the change log. 

Apart from that,

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew